It's not working because you didn't change the variable in the formula that I notated needed to be changed, you just wrote extra info next to them. You may have to correct the names here because I don't know the actual reference names of your datasource but just going off pictures it should be something similar to the following, where 'Job Site Scheduler' is the list name, status is the job state column, 'Job Name' is the project name and 'Team Leader' is the name to combine with the Job Name... Actual syntax of the code works fine, been tested on my own sharepoint list. Just need to get all your references to your own datasource proper.
//ADDS COLUMN TO CONCAT SITE AND JOB LEADER 1/2
AddColumns(
///FILTER RESULTS OF OUR LIST
Filter(
///ADDS A COLUMN THAT CONTAINS THE FIRST ITEM IN THE CHOICE COLUMN (JOB STATUS)
AddColumns(
///YOU WILL PUT YOUR JOB SITE LIST NAME HERE
'Job Site Scheduler',
///GIVE IT A NEW UNIQUE NAME HERE
"Test",
///YOU WILL PUT YOUR CHOICE COLUMN NAME HERE STATUS OR WHATEVER ITS NAME IS
First(status).Value
),
///CHANGE TEST = TO WHATEVER NAME YOU GAVE THE ADDED COLUMN ABOVE, Change "Pavers"
///to your status that you want to show on the list
Test="Not started"
),
///ADDS COLUMN TO CONCAT SITE AND JOB LEADER 2/2
"Contact",
////CHANGE THE TWO ContactName/ContactDepartment BELOW TO THE COLUMSN YOU WANT
////TO COMBINE
'Job Name'&" - "&'Team Leader'
)
If it doesn't recognize any of these, and they match what is displayed in your splist you will need to go into the splist settings, (gear icon, then click list settings), find the column that is giving you issues, click it, then look in the address bar of your browser, very last string is what powerapps is looking for when referencing your column.
And just to help out on future projects it would be best to keep list and columns names without spaces, so instead of Job Site Scheduler you would go JobSiteScheduler, Job Name becomes JobName etc.
