Unanswered

Patch function not working with For All and lookup

(0) Share

Report

Posted on by Community Power Pla... Microsoft Employee

Hi,

I have a gallery which contains questions and answers. Each question set is identified by TestIdentifier. E.g if i have a question set of 20 questions then its testidentifier will be same. I am putting all questions in collection . then I am iterating Collection & updating corresponding record in db using patch and lookup. This code is not giving error & also not doing anything. Below is the code & urgent help will be appreciated.

Clear(QuestCollect);

Collect(
QuestCollect,
ForAll(
Gallery_1.AllItems,
{
Answer: txtAnswer.Text,
QuestionID: lblQuestionID.Text,
TestIdentifier: lblTestIdentifier.Text,
Comments: txtComments_ExternalCor.Text
}
)
);

ForAll(
QuestCollect,
Patch(
'Test QuestionSet',
LookUp(
'Test QuestionSet',
QuestionID = QuestCollect[@QuestionID] && TestIdentifier = QuestCollect[@TestIdentifier]
),
{Answer: QuestCollect[@Answer]},
{Comments: QuestCollect[@Comments]}
)
);

Categories:

Building Power Apps

I have the same question (0)

All responses (5)

Answers (0)

Sort by

WarrenBelz 156,454 Most Valuable Professional on at

Like
a
(0)

Report
Copy link

Link copied!
Hi @Anonymous ,
I cannot see your data structure, but I have coded the below as I would from a collection with plain Text values.
You might try this.
ClearCollect( QuestCollect, ForAll( Gallery_1.AllItems, { Answer: txtAnswer.Text, QuestionID: lblQuestionID.Text, TestIdentifier: lblTestIdentifier.Text, Comments: txtComments_ExternalCor.Text } ) ); ForAll( QuestCollect, Patch( 'Test QuestionSet', LookUp( 'Test QuestionSet', QuestionID = QuestCollect.QuestionID && TestIdentifier = QuestCollect.TestIdentifier ), { Answer: QuestCollect.Answer, Comments: QuestCollect.Comments } ) )

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Was this reply helpful? Yes No
Community Power Pla... Microsoft Employee on at

Like
a
(0)

Report
Copy link

Link copied!

Thanks for your reply. This code is giving error "Invalid Argument Type" & is not working.

Was this reply helpful? Yes No
WarrenBelz 156,454 Most Valuable Professional on at

Like
a
(0)

Report
Copy link

Link copied!

What is giving the error?

Was this reply helpful? Yes No
Community Power Pla... Microsoft Employee on at

Like
a
(0)

Report
Copy link

Link copied!
Here its giving error at (=)
QuestionID = QuestCollect.QuestionID
I think @ is the proper syntax to get value from a collection field. My code runs without syntax error but it comes out from loop very quickly. I think its not executing the complete for each loop. I have already validated collection, It contains proper records.

Was this reply helpful? Yes No
WarrenBelz 156,454 Most Valuable Professional on at

Like
a
(0)

Report
Copy link

Link copied!
OK @Anonymous ,
This may be something in Regional syntax as .xxx works for me - you need to put them back.
Without seeing your code, there are two things I would initially test.
Have a look at the Collection QuestCollect and see if they are the records you were expecting.
Look at the fields in this QuestionID and TestIdentifier and ensure they match the relevant fields in 'Test QuestionSet'

Was this reply helpful? Yes No