Unanswered

Issues with ForAll function

(0) Share

Report

Posted on by TomiKasurinen

Hello,

I have a formula which worked great but started having issues when the datatable started growing. Data is stored in Dataverse.

So what the formula does is it checks if it has patched something already and ignores the patch if it has. It patches a certain number of new items to dataverse. This number is defined in a gallery row. ForAll then completes this formula for the specified amount of times.

Before issues I had Last(RIVITIEDOT).ID instead of First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID in my formula. But the Last function stopped showing the true last record of the table.

The issue Im having now is in ForAll function where First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID doesn't fetch the last record in time and it results in patching same ID multiple times. Is there a way to make ForAll function wait before it continues the sequence? Or is there a better way to do this?

Formula below:

Select(Parent);;
If(LookUp(RIVITIEDOT; Työnumero = ThisItem.ID; Työnumero) <> ThisItem.ID;
Patch(RIVITIEDOT; {ID: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1; Työnumero: ThisItem.ID; Rivinumero: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1});;
ForAll(Sequence(ThisItem.Määrä - 1); (If(Value(ThisItem.Määrä) > 1; Patch(RIVITIEDOT; {ID: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1; Työnumero: ThisItem.ID; Rivinumero: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1})))));;
Navigate(Screen_Rivitiedot; ScreenTransition.Cover)

BR,

Tomi

Categories:

Building Power Apps

I have the same question (0)

All responses (3)

Answers (0)

Sort by

BCLS776 8,994 Moderator on at

Like
a
(0)

Report
Copy link

Link copied!
I think you're running into delegation issues preventing you from getting the correct ID. ForAll() is not delegable, so the app is trying to load all the records and stops at the delegation limit for the app. Try this to help:

Select(Parent);; With({ nextID: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1}, If( LookUp(RIVITIEDOT; Työnumero = ThisItem.ID; Työnumero) <> ThisItem.ID; Patch(RIVITIEDOT; // you appear to be missing a second argument, perhaps Defaults(RIVITIEDOT) or a LookUp() { ID: nextID; Työnumero: ThisItem.ID; Rivinumero: nextID });; ForAll(Sequence(ThisItem.Määrä - 1); ( If(Value(ThisItem.Määrä) > 1; Patch(RIVITIEDOT; // you appear to be missing a second argument, perhaps Defaults(RIVITIEDOT) or a LookUp() { ID: nextID; Työnumero: ThisItem.ID; Rivinumero: nextID } ) ) ) ));; Navigate(Screen_Rivitiedot; ScreenTransition.Cover)

That's free-typed, but it should get you closer. Make sure to include a second argument in your Patch() functions.

Hope that helps,

Bryan

Was this reply helpful? Yes No
TomiKasurinen 2 on at

Like
a
(0)

Report
Copy link

Link copied!

This resulted in patching the same ID for all records.

I thought Patch() didn't need a second argument when making new items.

Was this reply helpful? Yes No
BCLS776 8,994 Moderator on at

Like
a
(0)

Report
Copy link

Link copied!
@TomiKasurinen wrote:

This resulted in patching the same ID for all records.

I thought Patch() didn't need a second argument when making new items.

Patch() uses two arguments when merging records; however, since you are creating items you need three arguments. The Defaults() function is what tells Patch() you are making a new record rather than updating an existing one.

To increment the ID as the ForAll() moves through the records, try this:

Select(Parent);; With({ nextID: First(Sort(RIVITIEDOT; Luotu; SortOrder.Descending)).ID + 1}, If( LookUp(RIVITIEDOT; Työnumero = ThisItem.ID; Työnumero) <> ThisItem.ID; Patch(RIVITIEDOT; // you appear to be missing a second argument, perhaps Defaults(RIVITIEDOT) or a LookUp() { ID: nextID; Työnumero: ThisItem.ID; Rivinumero: nextID });; ForAll(Sequence(ThisItem.Määrä - 1) As aIndex; ( If(Value(ThisItem.Määrä) > 1; Patch(RIVITIEDOT; // you appear to be missing a second argument, perhaps Defaults(RIVITIEDOT) or a LookUp() { ID: nextID; Työnumero: ThisItem.ID; Rivinumero: nextID + aIndex } ) ) ) ));; Navigate(Screen_Rivitiedot; ScreenTransition.Cover)

Bryan

Was this reply helpful? Yes No