Improving formula.

(1) Share

Report

Posted on by ADumith

277

Hello guys,

I have this formula, which is working fine, but I'm unsecure if this the best clear a professional code.

If(
 VarIsAssistant,
 Search(
 Filter(
 'matter engagement letters',
 'Engagement Letter Status' <> 'Engagement Letter Status Choice'.'Verified and complete',
 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value || IsBlank(txtSearchAttorney_1.Selected),
 Assistant.'Primary Email' = User().Email
 ),
 txtSearchMatter_1.Value,
 'Matter Name',
 MatterNumber
 ),
 Search(
 Filter(
 'matter engagement letters',
 'Engagement Letter Status' in txtSearchStatus_1.SelectedItems || IsBlank(txtSearchStatus_1.Selected),
 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value || IsBlank(txtSearchAttorney_1.Selected)
 ),
 txtSearchMatter_1.Value,
 'Matter Name',
 MatterNumber
 )
)

So, I wonder if you have an idea how to improve it.

Thank you,

Categories:

Building Power Apps

I have the same question (0)

All responses (13)

Answers (1)

Sort by

Ami K 15,689 Super User 2024 Season 1 on at

Like
a
(0)

Report
Copy link

Link copied!
@ADumith - in general I think your code looks fine to me (assume your data source is Dataverse).

My preference would be to leverage the With function to avoid repeating any lines of code as much as possible. I would also clean up your OR operators.

With( { filtered_data_one: Filter( 'matter engagement letters', 'Engagement Letter Status' <> 'Engagement Letter Status Choice'.'Verified and complete', Len(txtSearchAttorney_1.Selected.Value) = 0 || 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value, Assistant.'Primary Email' = User().Email ), filtered_data_two: Filter( 'matter engagement letters', CountRows(txtSearchStatus_1.SelectedItems) = 0 || IsBlank(txtSearchStatus_1.SelectedItems) || 'Engagement Letter Status' in txtSearchStatus_1.SelectedItems, Len(txtSearchAttorney_1.Selected.Value) = 0 || 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value ) }, With( { select_data: If( VarIsAssistant, filtered_data_one, filtered_data_two ) }, Search( select_data, txtSearchMatter_1.Value, 'Matter Name', MatterNumber ) ) )

Was this reply helpful? Yes No
Verified answer

ADumith 277 on at

Like
a
(1)

Report
Copy link

Link copied!
Hello,

Thank you for your reply.

I tried to use your code, but is not working.

The Len(txtSearchAttorney_1.Selected.'Full Name') is not working, actually it's returning the error:
Name isn't valid. 'Full name' isn't recognized

However, this formula is working fine, but I like your idea. So, we can fix the error I would love use your formula.

If( VarIsAssistant, Search( Filter( 'matter engagement letters', 'Engagement Letter Status' <> 'Engagement Letter Status Choice'.'Verified and complete', 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value || IsBlank(txtSearchAttorney_1.Selected), Assistant.'Primary Email' = User().Email ), txtSearchMatter_1.Value, 'Matter Name', MatterNumber ), Search( Filter( 'matter engagement letters', 'Engagement Letter Status' in txtSearchStatus_1.SelectedItems || IsBlank(txtSearchStatus_1.Selected), 'Billing Attorney'.'Full Name' = txtSearchAttorney_1.Selected.Value || IsBlank(txtSearchAttorney_1.Selected) ), txtSearchMatter_1.Value, 'Matter Name', MatterNumber ) )

Thank you,

Was this reply helpful? Yes No
mmbr1606 14,629 Super User 2026 Season 1 on at

Like
a
(0)

Report
Copy link

Link copied!

hey @ADumith

is there a reason why u want to change the code? If it works, i would not change anything to be honest 😉

Was this reply helpful? Yes No
ADumith 277 on at

Like
a
(0)

Report
Copy link

Link copied!

Hello @mmbr1606

I really don't want @Amik to feel that I don't value the effort in rewriting the formula.

It is a way of being grateful.

Does it make sense to you?

Was this reply helpful? Yes No
mmbr1606 14,629 Super User 2026 Season 1 on at

Like
a
(0)

Report
Copy link

Link copied!

Hey

No i was just asking in general nit about the answer of Amik, just wanted to know why u wamt to change tge exiating formula 😁

Was this reply helpful? Yes No
ADumith 277 on at

Like
a
(1)

Report
Copy link

Link copied!

Hello @mmbr1606

If there's one thing I've learned is that it's always possible to improve something, and @Amik 's idea is great, it's just not clear to me why it doesn't work.

I'm looking into it.

Have the best day possible.

Was this reply helpful? Yes No
Ami K 15,689 Super User 2024 Season 1 on at

Like
a
(0)

Report
Copy link

Link copied!

@ADumith - that is a good attitude to have. Just because something works does not mean it works in the most efficient way (and repeating lines of code is not efficient!).

I edited my code a few seconds after posting it yesterday, but it seems your browser caught the old version. Note in my code I have Len(txtSearchAttorney_1.Selected.Value)

Was this reply helpful? Yes No
ADumith 277 on at

Like
a
(0)

Report
Copy link

Link copied!

Hello @Amik ,

I was testing the formula and I realized something, when I apply it in the table something strange happens, it turns out that the column of the assistants is blank, no record is shown, but when I return to place the previous formula everything works again.

Do you have any idea why this behavior?

Thank you,

Was this reply helpful? Yes No
Ami K 15,689 Super User 2024 Season 1 on at

Like
a
(0)

Report
Copy link

Link copied!

@ADumith - when you say the "assistants" is blank, does that mean the rest of the columns in the record are still returned?

Was this reply helpful? Yes No
ADumith 277 on at

Like
a
(0)

Report
Copy link

Link copied!

@Amik

Let me show.

With my formula:

With your formula:

Was this reply helpful? Yes No