Unanswered

Solution Checker and PCF Component with React

(3) Share

Report

Posted on by Kristoffer88

Hi.

We are having some issues with running the solution checker on unmanaged PCF Components with React imported as a dependency.

If i take this example and compile a solution from it, it will give 398 errors from the solution checker (mostly from the react bundle)

https://github.com/microsoft/PowerApps-Samples/tree/master/component-framework/ReactStandardControl

Are there any ways to ignore external libraries or maybe i am compiling this in a wrong way?

msbuild /t:build /restore /p:configuration=Release

Categories:

Power Apps Pro Dev & ISV

I have the same question (0)

All responses (11)

Answers (0)

a33ik 3,306 Most Valuable Professional on at

Like (1)

Report

Hello Kristoffer,
Let me guess... The App Checker mostly barks on the usage of "top" wording?
I raised this issue with the product group but in my case, I had issues running App Checked with Html/JS WebResources. I will revisit my email box to restart the discussion.

Was this reply helpful? Yes No
Hemant Gaur on at

Like (0)

Report

Thanks for reporting @Kristoffer88 I have reported the issue and we will investigate this. @a33ik please loop me in the discussion with PG. There is work pending for PCF solution checker alignment and it would be helpful context.

Thanks,

Hemant

Was this reply helpful? Yes No
lesyk Microsoft Employee on at

Like (1)

Report
Today, I have had a call with another person who reported a very similar issue. In that specific case, the root cause was that they run building of PCF in a debug mode:

npm run build

For building production version of the package you should run:

npm run build -- --buildMode production

or

msbuild /p:configuration=Release

depending on your build system.

Solution checker is designed to check "production built" packages, not "debug" ones.

Next doc updates were made:
- Added: known issue for PCF by lesyk · Pull Request #2561 · MicrosoftDocs/powerapps-docs (github.com)
- Add: prod build version command by lesyk · Pull Request #2560 · MicrosoftDocs/powerapps-docs (github.com)

Also, issue on XRMToolbox was raised: [Feature]: Build and deployment of "Debug" version of PCF to the "Prod" environment · Issue #56 · Power-Maverick/PCF-CustomControlBuilder (github.com)

Was this reply helpful? Yes No
Kristoffer88 87 on at

Like (0)

Report

Hi. As you can see in my opening post, this is already build with
msbuild /t:build /restore /p:configuration=Release

The problem it seems, is that is it checking all the dependencies of my packages (react etc)

Was this reply helpful? Yes No
lesyk Microsoft Employee on at

Like (0)

Report
Is it possible for you to share more details:
1. Process of the build:
Did you opened terminal, navigated to your folder and just pasted:
msbuild /t:build /restore /p:configuration=Release
right? Or some other acitons/programs are used?

2. May you share a list of errors that you are getting for the https://github.com/microsoft/PowerApps-Samples/tree/master/component-framework/ReactStandardControl?
3. Is it is possible to provide files/recordings that would speedup the process?

Was this reply helpful? Yes No
Kristoffer88 87 on at

Like (0)

Report

I think it has to do, with the way i am building it as a unmanaged solution.

To my understanding this is needed to include it into a existing solution and exporting that to another environment

i do this by editing this:
solution.xml
line 12+13

<Managed>0</Managed>

and solution.cdsproj
line 19-21
  <PropertyGroup>
    <SolutionPackageType>Unmanaged</SolutionPackageType>
  </PropertyGroup>

This is to get a unmanaged component, that i can import into another solution and then exporting it as a managed for customers. Maybe there is a better practice to do this?

Here is a video of the build:

Build: https://streamable.com/o9q7en
Upload and Health Check results: https://streamable.com/ar6n5e

Was this reply helpful? Yes No
tmp123 2 on at

Like (0)

Report
Hello,
Did you find a solution to the problem @Kristoffer88 ? Or anyone else?
I am also building it as a unmanaged solution (.cdsproj file edited) and I also use:
msbuild /p:configuration=Release

Thanks

Edit:
The 4 types of issues I have:
web-avoid-window-top
web-remove-console
web-use-strict-equality-operators
web-use-strict-mode
But most issues seem to come from third party libraries.

Was this reply helpful? Yes No
Oranges 2 on at

Like (0)

Report

Hi, I'm currently working with PCF and I encounter the same error. Is it resolved now?

Was this reply helpful? Yes No
ashwini_uppin Microsoft Employee on at

Like (0)

Report
Hi, I'm also working with PCF and encountering the same error. Is it resolved now?

The 4 types of issues I have:
web-avoid-window-top
web-remove-console
web-use-strict-equality-operators
web-use-strict-mode

Was this reply helpful? Yes No
Phil Catterall 40 on at

Like (0)

Report

I also get the same issue. In my case I am building a solution that contains several controls, added as project references in the .cdsproj.
This I build with
dotnet build -t:Rebuild -p:Configuration=Release

Was this reply helpful? Yes No