Saving button is not generating the right data

(0) Share

Report

Posted on by Seth18

146

Hello everyone!

I have a code for my save button as below:

UpdateContext({SaveButtonPressed: true});
Set(
    ChangeNumberVar,
    Text(
        Value(DataCardValue22.Text),
        "[$-en-GB]$#,###.00"
    )
);
SubmitForm(Form5);
Set(
    showFormButtons,
    false
);
// Reset the visibility of the buttons
Patch(
    [@'Invoice Master'],
    LookUp(
        'Invoice Master',
        ID = Last(
            Sort(
                'Invoice Master',
                ID,
                SortOrder.Ascending
            )
        ).ID
    ),
    {'Request ID': DataCardValue10.Text}
);
Patch(
    [@'Expense Claim Automation'],
    LookUp(
        'Expense Claim Automation',
        Text(ID) = DataCardValue10.Text
    ),
    
    {
        'Total Amount:': Sum(
        Filter(
        Gallery3.AllItems,'Request ID' = Text(Gallery2.Selected.ID)),
        Amount)
    }
)
 
Background:
I'm building a Power App that integrates with two SharePoint lists for managing expense claims and invoices. Here’s an overview of the workflow:
SharePoint List 1 (Expense Claim Automation): This list stores basic user information. On the app's initial screen, users fill in this basic information, and when they click on the "Create Invoice" button, the data is submitted to SharePoint List 1. Submitting this form first ensures that the SharePoint ID is generated automatically.
SharePoint List 2 (Invoice Master): After submitting the basic information, users are redirected to an invoice screen where they can input more detailed information. When they finish, they click "Save," and this data is supposed to be submitted to SharePoint List 2.
Issue:
Currently, the detailed information from the invoice screen (SharePoint List 2) is not updating correctly. For example, when User A (ID=1) completes and submits an invoice, their data is saved correctly. However, when User B (ID=2) submits their invoice, instead of creating or updating their unique entry in SharePoint List 2, it overwrites or reuses the data associated with User A’s ID.
This means new user entries are not correctly saved in SharePoint List 2 and are instead referencing the previous user’s data, leading to data inaccuracies.
Request:
Could you assist in troubleshooting why the SharePoint List 2 submission does not capture the new user's data and instead references previous submissions? I'm aiming to ensure that each user's submission in SharePoint List 2 reflects their individual information based on their unique ID from SharePoint List 1

Categories:

Building Power Apps

I have the same question (0)

All responses (14)

Answers (0)

Suggested answer

mmbr1606 14,605 Super User 2025 Season 2 on at

Like (0)

Report
hey

can u try this approach:

UpdateContext({SaveButtonPressed: true}); Set( ChangeNumberVar, Text( Value(DataCardValue22.Text), "[$-en-GB]$#,###.00" ) ); SubmitForm(Form5); Set( showFormButtons, false ); Patch( [@'Invoice Master'], Defaults('Invoice Master'), { 'Request ID': DataCardValue10.Text, 'Change Number': ChangeNumberVar } ); Patch( [@'Expense Claim Automation'], LookUp( 'Expense Claim Automation', Text(ID) = DataCardValue10.Text ), { 'Total Amount:': Sum( Filter( Gallery3.AllItems, 'Request ID' = Text(Gallery2.Selected.ID) ), Amount ) } )

if it helped please mark as verified answer

cheers

Was this reply helpful? Yes No
Suggested answer

ronaldwalcott 3,847 Super User 2025 Season 2 on at

Like (0)

Report

How does this identify the correct user?

LookUp(

  'Invoice Master',

ID = Last(

  Sort(

  'Invoice Master',

ID,

  SortOrder.Ascending

  )

  ).ID

Isn't it just grabbing the last record?

Was this reply helpful? Yes No
Seth18 146 on at

Like (0)

Report

hi @mmbr1606,

I tried with your code it only submitting the amount while other info suddenly all wiped off.

Was this reply helpful? Yes No
Seth18 146 on at

Like (0)

Report

Hi @ronaldwalcott,

That a good point but how can i fix that part tho?

Was this reply helpful? Yes No
mmbr1606 14,605 Super User 2025 Season 2 on at

Like (0)

Report

you need to check the update property of the datacards and have a look whats in there

cheers

Was this reply helpful? Yes No
Suggested answer

ronaldwalcott 3,847 Super User 2025 Season 2 on at

Like (0)

Report

Should probably be something like

LookUp(

'Invoice Master',

ID = Form5.LastSubmit.ID

)

When you use SubmitForm, LastSubmit() retrieves the last record that was submitted. I am assuming that the Invoice record you want to save is associated with the same person but you haven't provided those details.

Was this reply helpful? Yes No
Seth18 146 on at

Like (0)

Report

Hi mmbr1606,

Your code suggestion is work with just some of adjustment as below:

UpdateContext({SaveButtonPressed: true});
Set(
ChangeNumberVar,
Text(
Value(DataCardValue22.Text),
"[$-en-GB]$#,###.00"
)
);
SubmitForm(Form5);
// Hide buttons or set other UI flags if needed
Set(
showFormButtons,
false
);
Patch(
[@'Invoice Master'],
Defaults('Invoice Master'),
Form5.Updates,
{
'Request ID': DataCardValue10.Text,
'Amount': ChangeNumberVar
}
);
Patch(
[@'Expense Claim Automation'],
LookUp(
'Expense Claim Automation',
Text(ID) = DataCardValue10.Text
),
{
'Total Amount:': Sum(
Filter(
Gallery3.AllItems,
'Request ID' = Text(Gallery2.Selected.ID)
),
Amount
)
}

but currently it only work when i selected Cash Advance but when i select Expense Claims it occurs a new error in the backend sharepoint of Invoice Master (As the below screenshot) it currently creating duplicate 2 data in which the first one is correct (but missing the request ID) wihle the other have the request ID (but missing the data)

Was this reply helpful? Yes No
mmbr1606 14,605 Super User 2025 Season 2 on at

Like (0)

Report
hey

can u try this approach:

UpdateContext({ SaveButtonPressed: true }); Set(ChangeNumberVar, Text(Value(DataCardValue22.Text), "[$-en-GB]$#,###.00")); SubmitForm(Form5); If( Form5.Valid, With( { requestID: DataCardValue10.Text }, Patch( [@'Invoice Master'], Defaults('Invoice Master'), Form5.Updates, { 'Request ID': requestID, 'Amount': ChangeNumberVar } ), Patch( [@'Expense Claim Automation'], LookUp('Expense Claim Automation', Text(ID) = requestID), { 'Total Amount:': Sum( Filter( Gallery3.AllItems, 'Request ID' = Text(Gallery2.Selected.ID) ), Amount ) } ) ) );

ifd my reply helped, please mark as verified answer

cheers

Was this reply helpful? Yes No
Seth18 146 on at

Like (0)

Report

Hi ronaldwalcott,

I tried your approach but it does not work as well! it only work just how i reply to the other guy

Was this reply helpful? Yes No
Seth18 146 on at

Like (0)

Report

Hi mmbr1606 ,

it show like this in the screenshot i've send to you!

Was this reply helpful? Yes No