Problem updating SharePoint List using ForAll/Patch

(0) Share

Report

Posted on by marsdendd

Hi Community,

I have an issue updating my SP List using ForAll and Patch. Expression below:

ForAll(
 colRiskRegisterAdd,
 Patch(
 RiskRegister,
 Defaults(RiskRegister),
 {
 RiskID: ThisRecord.ID,
 RiskGroup: ThisRecord.RiskGroup,
 Risk: ThisRecord.Risk,
 RiskCategory: ThisRecord.RiskCategory,
 RiskDescription: ThisRecord.RiskDescription,
 MonetaryImpact: numMonetaryImpact.Text,
 ReputationalImpact: numReputarionalImpact.Text,
 OperationalImpact: numOperationalImpact.Text,
 FinalImpactScore: numFinalImpactScore.Text,
 Likelihood: numLikelihood.Text,
 InherentRisk: numInherentRisk.Text,
 ControlEffectiveness: numControlEffectiveness.Text,
 ResidualRisk: numResidualRisk.Text 
 }
 )
);

The issue I face is the ForAll adds each Record as expected but adds the last entered set of numerical values to all records. What do i need to do to ensure that each record is updated with the corresponding set of numerical values.

Thanks

Categories:

Building Power Apps

I have the same question (0)

All responses (6)

Answers (0)

Sort by

notj 782 on at

Like (0)

Report
Copy link

Link copied!

@marsdendd OK, so what's the issue/error?

Was this reply helpful? Yes No
marsdendd 68 on at

Like (0)

Report
Copy link

Link copied!

The ForAll adds each Record as expected but adds the last entered set of numerical values. So when adding more than one record the same set of numerical values are updated to all records.

I understand the ForAll isnt a loop in the traditional sense but id appreciate any help on how to ensure the values are correctly written to the corresponding item.

Was this reply helpful? Yes No
WarrenBelz 154,930 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!
HI @marsdendd ,

Assuming all these fields are in the Collection, this should work

ForAll( colRiskRegisterAdd As aRisk, Patch( RiskRegister, Defaults(RiskRegister), { RiskID: aRisk.ID, RiskGroup: aRisk.RiskGroup, Risk: aRisk.Risk, RiskCategory: aRisk.RiskCategory, RiskDescription: aRisk.RiskDescription, MonetaryImpact: aRisk.numMonetaryImpact, ReputationalImpact: aRisk.numReputarionalImpact, OperationalImpact: aRisk.numOperationalImpact, FinalImpactScore: aRisk.numFinalImpactScore, Likelihood: aRisk.numLikelihood, InherentRisk: aRisk.numInherentRisk, ControlEffectiveness: aRisk.numControlEffectiveness, ResidualRisk: aRisk.numResidualRisk } ) )

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Was this reply helpful? Yes No
WarrenBelz 154,930 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

Hi @marsdendd

Just checking if you got the result you were looking for on this thread. Happy to help further if not.

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

Was this reply helpful? Yes No
marsdendd 68 on at

Like (0)

Report
Copy link

Link copied!
Hi @WarrenBelz

Thanks for coming back on this. Sorry for my late reply. I wasn't alerted until today that there had been a response.

Ok so i tried the proposed solution and unfortunately it didn't have the desired outcome.

The inclusion of the following in the collection returns a "The type of this argument does not match the expected type "Text" (tried changing SP list column to number and got similar error except type "Number")

MonetaryImpact: aRisk.numMonetaryImpact, ReputationalImpact: aRisk.numReputarionalImpact, OperationalImpact: aRisk.numOperationalImpact, FinalImpactScore: aRisk.numFinalImpactScore, Likelihood: aRisk.numLikelihood, InherentRisk: aRisk.numInherentRisk, ControlEffectiveness: aRisk.numControlEffectiveness, ResidualRisk: aRisk.numResidualRisk

Darren

Was this reply helpful? Yes No
WarrenBelz 154,930 Most Valuable Professional on at

Like (0)

Report
Copy link

Link copied!

@marsdendd ,

Where are the values you have noted as Text coming from? I assumed they were fields in the collection.

Was this reply helpful? Yes No