Answered

Invalid data source for ForAll function (and embedded Patch & Lookup functions)

(0) Share

Report

Posted on by JoAnneCharlotte

Hello,

I'm trying to create a bulk update on my timesheet data PowerApp. I have a data table, drop downs for filters and then a button called Bulk Edit Status. OnSelect on the button I'm creating a new collection called colFilteredTimesheets - which contains all the currently displayed timesheet entries based on the filters set by the users. I've checked and the collection is being created successfully.

My user will then choose a Status value from a drop down box and I want to bulk update all records to the new status. I have the following code on my save button:

ForAll(
    RenameColumns(
        colFilteredTimesheets,
        "ID",
        "PT ID"
    ),
    Patch(colFilteredTimesheets,
        LookUp(colFilteredTimesheets,ID = 'PT ID'),
        {Status: drpBulkEditStatus.SelectedText}
    )
)

I'm getting an error saying "The data source supplied to the function is invalid".

Any suggestions?

Thank you 🙂

Jo-Anne

Categories:

Building Power Apps

I have the same question (0)

All responses (8)

Answers (1)

Sort by

Community Power Pla... Microsoft Employee on at

Like (0)

Report
Copy link

Link copied!
@JoAnneCharlotte
Are you just trying to update 'Status' for all records in your collection (ie colFilteredTimesheets) OR are you attempting to update a data source, such as SharePoint?

If you are just updating your collection, something like this should work:
UpdateIf( colFilteredTimesheets, true, {Status: drpBulkEditStatus.SelectedText} )

Was this reply helpful? Yes No
JoAnneCharlotte 61 on at

Like (0)

Report
Copy link

Link copied!

Both eventually. The data is collected in the app, I’m trying to update all records in the collection (code I posted). Once I got that working I will need to sync the updated records in the collection back to SP.

Was this reply helpful? Yes No
Community Power Pla... Microsoft Employee on at

Like (0)

Report
Copy link

Link copied!

Ok. Did you try the code I posted? Did it work?

Was this reply helpful? Yes No
JoAnneCharlotte 61 on at

Like (0)

Report
Copy link

Link copied!

just tried it - no luck - getting a new error "Invalid argument type. Expecting a Record value, but of a different schema."

I checked my colFilteredTimesheets collection, it's been created and the Status field is present...

Plot thickens! Any other suggestions?

Was this reply helpful? Yes No
JoAnneCharlotte 61 on at

Like (0)

Report
Copy link

Link copied!

Update - I've managed to get the ForAll to work - I'm struggling to understand how TBH - I posted last night (early morning) with the issue, then went to bed - came back online and tried the UpdateIF, that didn't work so tried ForAll again and now it works... anyway...

Now that my collection is updated I need to send the updates back to the SharePoint list - is ForAll going to work for this or am I am hit delegation issues?

Any suggestions for alternatives to save back to SP?

Thank you! 🙂

Was this reply helpful? Yes No
Community Power Pla... Microsoft Employee on at

Like (0)

Report
Copy link

Link copied!

@JoAnneCharlotte
Could you please post the code you got to work. I suspect you will need to use ForAll and Patch again due to the schema error you were getting.

Was this reply helpful? Yes No
JoAnneCharlotte 61 on at

Like (0)

Report
Copy link

Link copied!

Hi - it’s the code in the original post... I’d lost a comma at some point and my data table had a different source so it looked like nothing had happened.

Was this reply helpful? Yes No
Verified answer

v-xida-msft Microsoft Employee on at

Like (0)

Report
Copy link

Link copied!
Hi @JoAnneCharlotte ,

Do you want to patch the updated colFilteredTimesheets collection back to your SP List?

Based on the needs that you mentioned, I think the ForAll function and Patch function could achieve your needs. On your side, you should type the following formula:

ForAll( colFilteredTimesheets, Patch( 'Your SP List', LookUp('Your SP List', ID = colFilteredTimesheets[@ID]), { Title: colFilteredTimesheets[@Title], Status: colFilteredTimesheets[@Status], ... ... } ) )

The above ForAll formula would not cause a Delegation warning issue, the colFilteredTimesheets is a collection, which is not subject to Delegation issue.

Note: The RenameColumns function is not a Delegable function, so please remove the RenameColumns function from your ForAll formula, otherwise, it would cause a Delegation issue.

Best regards,

Was this reply helpful? Yes No