Answered

Collect() in dynamic gallery adding duplicate rows when the values are edited

(0) Share

Report

Posted on by MisbahKhwaja

Hi all, I've made a management system with dynamic fields and values. When new records are inserted it is working fine but when I want to change any value in my collection before submitting to Sharepoint, it is creating duplicate rows with updated values. Duplicates values are causing trouble for me. I've used OnChange trigger to fill values in collection. Please help me to find solution. Thanks

Categories:

Building Power Apps

issue.png

I have the same question (0)

All responses (12)

Answers (1)

SebS 4,616 Moderator on at

Like (1)

Report

@MisbahKhwaja

You did not specify record

in your screen you pointing to collection than you only did condition but when condition is meet you need point to record

UpdateIf( DataSource, Condition1, ChangeRecord1 [, Condition2, ChangeRecord2, ... ] )

Was this reply helpful? Yes No
MisbahKhwaja 34 on at

Like (0)

Report

I'm using this to insert updated values in collection
{BehManComment: ManagerComment_6.Text}
but it is creating two rows of updated value.

Was this reply helpful? Yes No
SebS 4,616 Moderator on at

Like (1)

Report
@MisbahKhwaja

it will be helpful if You past your code rather do screen of it.

UpdateIf(colbehavioralEvalist, BEID = Lable_6.Text,//Condition Value(Lable6.Text)//<---Record {BehManComment: ManagerComment_6.Text}) // Update

Was this reply helpful? Yes No
MisbahKhwaja 34 on at

Like (0)

Report

Here is my code
Collect(
colBehavioralEvaList,
{
BehDes: Description_6.Text,
BehRating: Rating_6.SelectedText.Value,
BehManComment: ManagerComment_6.Text,
BehEmpComment: "",
BEID: Label1_6.Text
}
);

UpdateIf( colBehavioralEvaList, BEID = Label1_6.Text, {BehManComment: ManagerComment_6.Text});

Was this reply helpful? Yes No
SebS 4,616 Moderator on at

Like (1)

Report
@MisbahKhwaja

So if BEID is not ID of the record you need to find it, same as SharePoint Collection create them own ID

UpdateIf( colBehavioralEvaList, BEID = Label1_6.Text, Lookup(colBehavioralEvaList,BEID = Label1_6.Text,ID), { BehManComment: ManagerComment_6.Text } );

Was this reply helpful? Yes No
SebS 4,616 Moderator on at

Like (0)

Report

@MisbahKhwaja

The real question is how You using this and what validating the condition ?

do You have a form or something and if the form is in edit mode You than Updating ?

or how this works ?

if you have both code in one button that do not have much sense or I'm thinking it wrong

Was this reply helpful? Yes No
MisbahKhwaja 34 on at

Like (0)

Report

BEID is my record ID. Label1_6 = ThisItem.ID.

Was this reply helpful? Yes No
Verified answer

SebS 4,616 Moderator on at

Like (1)

Report
@MisbahKhwaja

I think this should work better

so in this scenario You checking if BEID exist if not You collecting and if it exist You patching update

If(IsBlank(Lookup(colBehavioralEvaList,BEID = Label1_6.Text,ID)), Collect( colBehavioralEvaList, { BehDes: Description_6.Text, BehRating: Rating_6.SelectedText.Value, BehManComment: ManagerComment_6.Text, BehEmpComment: "", BEID: Label1_6.Text } ), Patch(colBehavioralEvaList, Lookup(colBehavioralEvaList,BEID = Label1_6.Text,ID), { BehManComment: ManagerComment_6.Text } ) )

Was this reply helpful? Yes No
SebS 4,616 Moderator on at

Like (0)

Report
@MisbahKhwaja

If You updating / patching to record what you hold in gallery there is even easier way.

assuming your button is outside of the gallery you can do something like that

Patch(colBehavioralEvaList, GalleryName.Selected, { BehManComment: ManagerComment_6.Text } )

but if you collect and update under same button you need to create something what will let the function know when to do the task.

If you collect first and than update you will duplicate the record as every time it will first create new record and than update it but you do not see the update

Was this reply helpful? Yes No
Ethan_009 4,838 Moderator on at

Like (1)

Report
Hi @MisbahKhwaja ,

To ensure duplicate records aren't created, use the following code:
If( ThisItem.ID in colBehavioralEvalist.BEID, Update( colBehavioralEvalist, { BehDes: Description 6.Text, BehRating: Rating 6.SelectedText.Value, BehManComment: Manager Comment_6.Text, BehEmpComment: "" } ), Collect( colBehavioralEvalist, { BehDes: Description 6.Text, BehRating: Rating 6.SelectedText.Value, BehManComment: Manager Comment_6.Text, BehEmpComment: "", BEID: Label1_6.Text } ) )

Hope this helps

Was this reply helpful? Yes No