Updating database from collection in a ForAll

(1) Share

Report

Posted on by SonnichJensen

Hi all

I have a collection, allowing user to update all data then save all.

I use a ForAll to add or update all. However, the update only updates the first record with data from the last record.

Seems like ThisRecord.id is from first and .name is from last.

What is wrong here?

ForAll(palletList,

If(ThisRecord.id=Blank(),

Notify(Concatenate("Pallet add", ThisRecord.item),NotificationType.Success,500);

Patch(outbound_pallets, Defaults(outbound_pallets),

{ pallet_id: ThisRecord.pallet_id,

item: ThisRecord.item,

quantity: ThisRecord.quantity,

comment: ThisRecord.comment,

trip_id: tripList.Selected.id }),

// else

Notify(Concatenate("Pallet update ", ThisRecord.id, ",", ThisRecord.item, ",",ThisRecord.quantity),NotificationType.Error,500);

Patch([@outbound_pallets], LookUp(outbound_pallets, id=ThisRecord.id),

{ pallet_id: ThisRecord.pallet_id,

item: ThisRecord.item,

quantity: ThisRecord.quantity,

comment: ThisRecord.comment,

trip_id: tripList.Selected.id });

);

Categories:

Building Power Apps

I have the same question (0)

All responses (3)

Answers (1)

Sort by

mmbr1606 14,629 Super User 2026 Season 1 on at

Like
a
(1)

Report
Copy link

Link copied!
hey @SonnichJensen

can u try this:

ForAll(palletList, If(IsBlank(ThisRecord.id), Notify(Concatenate("Pallet add: ", ThisRecord.item), NotificationType.Success, 500); Patch(outbound_pallets, Defaults(outbound_pallets), { pallet_id: ThisRecord.pallet_id, item: ThisRecord.item, quantity: ThisRecord.quantity, comment: ThisRecord.comment, trip_id: tripList.Selected.id }), Notify(Concatenate("Pallet update: ", ThisRecord.id, " Item: ", ThisRecord.item, " Qty: ", ThisRecord.quantity), NotificationType.Information, 500); Patch(outbound_pallets, LookUp(outbound_pallets, id = ThisRecord.id), { pallet_id: ThisRecord.pallet_id, item: ThisRecord.item, quantity: ThisRecord.quantity, comment: ThisRecord.comment, trip_id: tripList.Selected.id }); ) );

Let me know if my answer helped solving your issue.

If it did please accept as solution and give it a thumbs up so we can help others in the community.

Greetings

Was this reply helpful? Yes No
SonnichJensen 40 on at

Like
a
(1)

Report
Copy link

Link copied!

Can you say what you changed?

Was this reply helpful? Yes No
Verified answer

SonnichJensen 40 on at

Like
a
(1)

Report
Copy link

Link copied!

I nailed it.
ThisRecord refers to the item it is in, so ThisRecord within the LookUp is is for the present record within the LookUp. Therefore id=ThisRecord.id is always true.

The solution comes with the keyword As

ForAll(palletList As pl,
...
// else
Patch([@outbound_pallets], LookUp(outbound_pallets, id=pl.id),
{ pallet_id: pl.pallet_id,
item: pl.item,
quantity: pl.quantity,
comment: pl.comment,
trip_id: tripList.Selected.id });
);
);

Was this reply helpful? Yes No