Patching really slow to SharePointsList?

(0) Share

Report

Posted on by TimmyBoy

997

Hello,

I was wondering if someone has a better solution for patching to SharePointsList

It takes really more then 5 minutes to update a simple line or lines
My code:

If(Connection.Connected;
IfError(
 
 ForAll(
 colPickUp1;
 Patch(
 OnlineData;ThisRecord;
 { 
 PickUp:1
 } 
 ))
 ;UpdateContext({varShowPopup22:false});;Set(ShowAccessError;true);;Set(varError;FirstError.Message)
 ;
 UpdateContext({varShowPopup22:false});;Reset(Gallery3_2);;UpdateContext({checkedout:Blank()});;Refresh(OnlineData);;Clear(colPickUp1);;UpdateContext({varall1:false});;
UpdateContext({varall:false});;
UpdateContext({IsReset:false});;
UpdateContext({IsReset:true})
 )

;
Set(varNoconnection;true)
)

Is there something wrong with the code? why it going that slow

Thank you

Categories:

Building Power Apps

All responses (2)

Answers (1)

Sort by

Verified answer

WarrenBelz 156,736 Most Valuable Professional on at

Like
a
(1)

Report
Copy link

Link copied!
Hi @TimmyBoy ,

I will offer some fundamental advice here that may assist with this and future ForAll() exercises. It is not designed to be a Loop, although it can work this way with considerable performance penalty as it does an individual Patch for each record. ForAll() creates a Table, which can be patched in one action provided its content is correct. For new records, this is simply a Table with field names and field types matching the list. For existing records, including the SharePoint record ID in the table causes it to update that record for each of the Table records.
I have also consolidated a few things in the code below and am also wondering whether the first varShowPopup22 maybe should be true.
You also do not generally need to refresh data sources (this adds to the time taken and any galleries or forms based on the List should refresh automatically)

If( Connection.Connected; IfError( Patch( OnlineData; ForAll( colPickUp1 As _Data; { ID: _Data.ID; PickUp: 1 ) ) ); UpdateContext({varShowPopup22: false});; Set( ShowAccessError; true );; Set( varError; FirstError.Message ); Reset(Gallery3_2);; UpdateContext( { varShowPopup22: false; checkedout: Blank(); varall1: false; varall: false; IsReset: false } );; Clear(colPickUp1);; UpdateContext({IsReset: true}) ); Set( varNoconnection; true ) )

Please click Accept as solution if my post helped you solve your issue. This will help others find it more readily. It also closes the item. If the content was useful in other ways, please consider giving it Thumbs Up.

MVP (Business Applications) Visit my blog Practical Power Apps
TimmyBoy 997 on at

Like
a
(0)

Report
Copy link

Link copied!

Hello @WarrenBelz
I didn't know about this future ForAll() exercises, was a loop
I will try-out the code you provided me

Thank you.